From c03095d94fe218d25be1e9c8b4f1812d1c591b19 Mon Sep 17 00:00:00 2001 From: dynaflash Date: Mon, 27 Dec 2010 16:22:21 +0000 Subject: [PATCH] MacGui: Free the source display name for the ui before re-allocating it when doing a queue edit rescan. - Fixes a consistent crash when trying to edit a queue item. git-svn-id: svn://localhost/HandBrake/trunk@3714 b64f7644-9d1e-0410-96f1-a4d463321fa5 --- macosx/Controller.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/macosx/Controller.m b/macosx/Controller.m index 720e9e2a..78d99280 100644 --- a/macosx/Controller.m +++ b/macosx/Controller.m @@ -2687,8 +2687,10 @@ fWorkingCount = 0; fqueueEditRescanItemNum = selectedQueueItem; [self writeToActivityLog: "rescanQueueItemToMainWindow: Re-scanning queue item at index:%d",fqueueEditRescanItemNum]; applyQueueToScan = YES; + /* Make sure we release the display name before reassigning it */ + [browsedSourceDisplayName release]; /* Set the browsedSourceDisplayName for showNewScan */ - browsedSourceDisplayName = [[QueueFileArray objectAtIndex:fqueueEditRescanItemNum] objectForKey:@"SourceName"]; + browsedSourceDisplayName = [[[QueueFileArray objectAtIndex:fqueueEditRescanItemNum] objectForKey:@"SourceName"] retain]; [self performScan:scanPath scanTitleNum:scanTitleNum]; } -- 2.11.0