WinGui:

- Comments regarding bugs in the Parser. These will need fixed.

git-svn-id: svn://localhost/HandBrake/trunk@705 b64f7644-9d1e-0410-96f1-a4d463321fa5

diff --git a/win/C#/Parsing/AudioTrack.cs b/win/C#/Parsing/AudioTrack.cs
index 268007c..9739497 100644 (file)
--- a/win/C#/Parsing/AudioTrack.cs
+++ b/win/C#/Parsing/AudioTrack.cs
@@ -76,6 +76,12 @@ namespace Handbrake.Parsing
                 thisTrack.m_trackNumber = int.Parse(splitter[0]);\r
                 thisTrack.m_language = splitter[1];\r
                 thisTrack.m_format = splitter[2];\r
+                /*\r
+                 * Problem 2\r
+                 * Field 'Handbrake.frmMain.hbProc' is never assigned to, and will always have it's default value null.\r
+                 * This happens with "AllAudios.iso" which is a test file. http://www.sr88.co.uk/AllAudios.iso  (~95MB)\r
+                 */\r
+\r
                 thisTrack.m_subFormat = splitter[3];\r
                 thisTrack.m_frequency = int.Parse(splitter[4]);\r
                 thisTrack.m_bitrate = int.Parse(splitter[5]);\r

diff --git a/win/C#/Parsing/Title.cs b/win/C#/Parsing/Title.cs
index e55bd78..13795c4 100644 (file)
--- a/win/C#/Parsing/Title.cs
+++ b/win/C#/Parsing/Title.cs
@@ -124,6 +124,28 @@ namespace Handbrake.Parsing
                 curLine = output.ReadLine();\r
                 splitter = curLine.Split(new string[] { "  + autocrop: ", "/" }, StringSplitOptions.RemoveEmptyEntries);\r
                 thisTitle.m_autoCrop = new int[4] { int.Parse(splitter[0]), int.Parse(splitter[1]), int.Parse(splitter[2]), int.Parse(splitter[3]) };\r
+\r
+                /* \r
+                 * \r
+                 * A Few Bugs that need fixed.\r
+                 * \r
+                 * \r
+                 * Problem 1\r
+                 * There is a small problem here... What happens if the DVD has no Subtitles? or Handbrake misses the Audio or Chapter track \r
+                 * data due to an error.\r
+                 * \r
+                 * hbcli will sit in a suspended state until it is forcefully closed.\r
+                 * \r
+                 * Problem 2\r
+                 * See AudioTrack.cs Line 80 for details\r
+                 * \r
+                 * Problem 3\r
+                 * Doesn't seem to support DVD's where the first track is 0 instead of 1, and only includes 1 title (TS/MPG files)\r
+                 * Simply Doesn't list any titles.\r
+                 * \r
+                 * \r
+                 */\r
+         \r
                 thisTitle.m_chapters.AddRange(Chapter.ParseList(output));\r
                 thisTitle.m_audioTracks.AddRange(AudioTrack.ParseList(output));\r
                 thisTitle.m_subtitles.AddRange(Subtitle.ParseList(output));\r