OSDN Git Service

MacGui: Fix the quality slider setting when using presets for ffmpeg and theora.
authordynaflash <dynaflash@b64f7644-9d1e-0410-96f1-a4d463321fa5>
Wed, 24 Jun 2009 14:59:47 +0000 (14:59 +0000)
committerdynaflash <dynaflash@b64f7644-9d1e-0410-96f1-a4d463321fa5>
Wed, 24 Jun 2009 14:59:47 +0000 (14:59 +0000)
- Fix issue where ffmpeg's presets were 2.0 low on the slider.
- Fix theora presets to recognize that the slider is not "inverted" (qp value go higher as quality increases).
-Tested all tree encoders to verify that value saved in preset is reset in gui and reported correctly by libhb.

git-svn-id: svn://localhost/HandBrake/trunk@2614 b64f7644-9d1e-0410-96f1-a4d463321fa5

macosx/Controller.mm

index 63523dc..faeb0cc 100644 (file)
@@ -6121,7 +6121,16 @@ return YES;
         }
         else
         {
-            [fVidQualitySlider setFloatValue:([fVidQualitySlider maxValue] - [fVidQualitySlider minValue]) - [[chosenPreset objectForKey:@"VideoQualitySlider"] floatValue]];
+            /* Since theora's qp value goes up from left to right, we can just set the slider float value */
+            if ([[fVidEncoderPopUp selectedItem] tag] == HB_VCODEC_THEORA)
+            {
+                [fVidQualitySlider setFloatValue:[[chosenPreset objectForKey:@"VideoQualitySlider"] floatValue]];
+            }
+            else
+            {
+                /* since ffmpeg and x264 use an "inverted" slider (lower qp/rf values indicate a higher quality) we invert the value on the slider */
+                [fVidQualitySlider setFloatValue:([fVidQualitySlider maxValue] + [fVidQualitySlider minValue]) - [[chosenPreset objectForKey:@"VideoQualitySlider"] floatValue]];
+            }
         }
         
         [self videoMatrixChanged:nil];