OSDN Git Service

LinGui: fix a picture settings storage dimensions problem
[handbrake-jp/handbrake-jp-git.git] / gtk / src / hb-backend.c
index 0c3aac9..eca539e 100644 (file)
@@ -69,6 +69,19 @@ index_str_init(gint max_index)
        }
 }
 
+static options_map_t d_when_complete_opts[] =
+{
+       {"Do Nothing",            "nothing",  0, "0"},
+       {"Show Notification",     "notify",   1, "1"},
+       {"Put Computer To Sleep", "sleep",    2, "2"},
+       {"Shutdown Computer",     "shutdown", 3, "3"},
+};
+combo_opts_t when_complete_opts =
+{
+       sizeof(d_when_complete_opts)/sizeof(options_map_t),
+       d_when_complete_opts
+};
+
 static options_map_t d_par_opts[] =
 {
        {"Off", "0", 0, "0"},
@@ -107,6 +120,32 @@ combo_opts_t logging_opts =
        d_logging_opts
 };
 
+static options_map_t d_log_longevity_opts[] =
+{
+       {"Week",     "week",     7, "7"},
+       {"Month",    "month",    30, "30"},
+       {"Year",     "year",     365, "365"},
+       {"Immortal", "immortal", 366, "366"},
+};
+combo_opts_t log_longevity_opts =
+{
+       sizeof(d_log_longevity_opts)/sizeof(options_map_t),
+       d_log_longevity_opts
+};
+
+static options_map_t d_appcast_update_opts[] =
+{
+       {"Never", "never", 0, "never"},
+       {"Daily", "daily", 1, "daily"},
+       {"Weekly", "weekly", 2, "weekly"},
+       {"Monthly", "monthly", 3, "monthly"},
+};
+combo_opts_t appcast_update_opts =
+{
+       sizeof(d_appcast_update_opts)/sizeof(options_map_t),
+       d_appcast_update_opts
+};
+
 static options_map_t d_vqual_granularity_opts[] =
 {
        {"0.2",  "0.2",  0.2,  "0.2"},
@@ -124,7 +163,6 @@ static options_map_t d_container_opts[] =
 {
        {"MKV", "mkv", HB_MUX_MKV, "mkv"},
        {"MP4", "mp4", HB_MUX_MP4, "mp4"},
-       {"M4V", "m4v", HB_MUX_MP4, "m4v"},
 };
 combo_opts_t container_opts =
 {
@@ -319,9 +357,12 @@ typedef struct
 
 combo_name_map_t combo_name_map[] =
 {
+       {"WhenComplete", &when_complete_opts},
        {"PicturePAR", &par_opts},
        {"PictureModulus", &alignment_opts},
        {"LoggingLevel", &logging_opts},
+       {"LogLongevity", &log_longevity_opts},
+       {"check_updates", &appcast_update_opts},
        {"VideoQualityGranularity", &vqual_granularity_opts},
        {"FileFormat", &container_opts},
        {"PictureDeinterlace", &deint_opts},
@@ -342,6 +383,43 @@ combo_name_map_t combo_name_map[] =
        {NULL, NULL}
 };
 
+const gchar *srt_codeset_table[] =
+{
+       "ANSI_X3.4-1968",
+       "ANSI_X3.4-1986",
+       "ANSI_X3.4",
+       "ANSI_X3.110-1983",
+       "ANSI_X3.110",
+       "ASCII",
+       "ECMA-114",
+       "ECMA-118",
+       "ECMA-128",
+       "ECMA-CYRILLIC",
+       "IEC_P27-1",
+       "ISO-8859-1",
+       "ISO-8859-2",
+       "ISO-8859-3",
+       "ISO-8859-4",
+       "ISO-8859-5",
+       "ISO-8859-6",
+       "ISO-8859-7",
+       "ISO-8859-8",
+       "ISO-8859-9",
+       "ISO-8859-9E",
+       "ISO-8859-10",
+       "ISO-8859-11",
+       "ISO-8859-13",
+       "ISO-8859-14",
+       "ISO-8859-15",
+       "ISO-8859-16",
+       "UTF-7",
+       "UTF-8",
+       "UTF-16",
+       "UTF-32",
+       NULL
+};
+#define        SRT_TABLE_SIZE (sizeof(srt_codeset_table)/ sizeof(char*)-1)
+
 #if 0
 typedef struct iso639_lang_t
 {
@@ -994,7 +1072,7 @@ ghb_subtitle_track_source(signal_user_data_t *ud, gint track)
        gint titleindex;
 
        if (track == -2)
-               return CC608SUB;
+               return SRTSUB;
        if (track < 0)
                return VOBSUB;
        titleindex = ghb_settings_combo_int(ud->settings, "title");
@@ -1029,7 +1107,7 @@ ghb_subtitle_track_source_name(signal_user_data_t *ud, gint track)
 
        if (track == -2)
        {
-               name = "Text";
+               name = "SRT";
                goto done;
        }
        if (track == -1)
@@ -1066,9 +1144,11 @@ ghb_subtitle_track_source_name(signal_user_data_t *ud, gint track)
                                break;
                        case CC708SUB:
                        case CC608SUB:
-                       case SRTSUB:
                                name = "Text";
                                break;
+                       case SRTSUB:
+                               name = "SRT";
+                               break;
                        default:
                                break;
                }
@@ -1487,6 +1567,33 @@ mix_opts_set(GtkBuilder *builder, const gchar *name)
 }
 
 static void
+srt_codeset_opts_set(GtkBuilder *builder, const gchar *name)
+{
+       GtkTreeIter iter;
+       GtkListStore *store;
+       gint ii;
+       
+       g_debug("srt_codeset_opts_set ()\n");
+       store = get_combo_box_store(builder, name);
+       gtk_list_store_clear(store);
+       for (ii = 0; ii < SRT_TABLE_SIZE; ii++)
+       {
+               gtk_list_store_append(store, &iter);
+               gtk_list_store_set(store, &iter, 
+                                                  0, srt_codeset_table[ii],
+                                                  1, TRUE, 
+                                                  2, srt_codeset_table[ii],
+                                                  3, (gdouble)ii, 
+                                                  4, srt_codeset_table[ii],
+                                                  -1);
+       }
+       GtkComboBoxEntry *cbe;
+
+       cbe = GTK_COMBO_BOX_ENTRY(GHB_WIDGET(builder, name));
+       //gtk_combo_box_entry_set_text_column(cbe, 0);
+}
+
+static void
 language_opts_set(GtkBuilder *builder, const gchar *name)
 {
        GtkTreeIter iter;
@@ -1803,6 +1910,32 @@ ghb_longest_title()
        return titleindex;
 }
 
+gchar*
+ghb_get_source_audio_lang(gint titleindex, gint track)
+{
+       hb_list_t  * list;
+       hb_title_t * title;
+    hb_audio_config_t * audio;
+       gchar *lang = NULL;
+       
+       g_debug("ghb_lookup_1st_audio_lang ()\n");
+       if (h_scan == NULL) 
+               return NULL;
+       list = hb_get_titles( h_scan );
+    title = (hb_title_t*)hb_list_item( list, titleindex );
+       if (title == NULL)
+               return NULL;
+       if (hb_list_count( title->list_audio ) <= track)
+               return NULL;
+
+       audio = hb_list_audio_config_item(title->list_audio, track);
+       if (audio == NULL)
+               return NULL;
+
+       lang = g_strdup(audio->lang.iso639_2);
+       return lang;
+}
+
 gint
 ghb_find_audio_track(
        gint titleindex, 
@@ -2072,7 +2205,9 @@ ghb_lookup_combo_int(const gchar *name, const GValue *gval)
                return lookup_video_rate_int(gval);
        else if (strcmp(name, "AudioMixdown") == 0)
                return lookup_mix_int(gval);
-       else if (strcmp(name, "SourceAudioLang") == 0)
+       else if (strcmp(name, "SrtLanguage") == 0)
+               return lookup_audio_lang_int(gval);
+       else if (strcmp(name, "PreferredLanguage") == 0)
                return lookup_audio_lang_int(gval);
        else
        {
@@ -2095,7 +2230,9 @@ ghb_lookup_combo_double(const gchar *name, const GValue *gval)
                return lookup_video_rate_int(gval);
        else if (strcmp(name, "AudioMixdown") == 0)
                return lookup_mix_int(gval);
-       else if (strcmp(name, "SourceAudioLang") == 0)
+       else if (strcmp(name, "SrtLanguage") == 0)
+               return lookup_audio_lang_int(gval);
+       else if (strcmp(name, "PreferredLanguage") == 0)
                return lookup_audio_lang_int(gval);
        else
        {
@@ -2118,7 +2255,9 @@ ghb_lookup_combo_option(const gchar *name, const GValue *gval)
                return lookup_video_rate_option(gval);
        else if (strcmp(name, "AudioMixdown") == 0)
                return lookup_mix_option(gval);
-       else if (strcmp(name, "SourceAudioLang") == 0)
+       else if (strcmp(name, "SrtLanguage") == 0)
+               return lookup_audio_lang_option(gval);
+       else if (strcmp(name, "PreferredLanguage") == 0)
                return lookup_audio_lang_option(gval);
        else
        {
@@ -2141,7 +2280,9 @@ ghb_lookup_combo_string(const gchar *name, const GValue *gval)
                return lookup_video_rate_option(gval);
        else if (strcmp(name, "AudioMixdown") == 0)
                return lookup_mix_option(gval);
-       else if (strcmp(name, "SourceAudioLang") == 0)
+       else if (strcmp(name, "SrtLanguage") == 0)
+               return lookup_audio_lang_option(gval);
+       else if (strcmp(name, "PreferredLanguage") == 0)
                return lookup_audio_lang_option(gval);
        else
        {
@@ -2188,14 +2329,19 @@ ghb_update_ui_combo_box(
                audio_samplerate_opts_set(ud->builder, "AudioSamplerate", hb_audio_rates, hb_audio_rates_count);
                video_rate_opts_set(ud->builder, "VideoFramerate", hb_video_rates, hb_video_rates_count);
                mix_opts_set(ud->builder, "AudioMixdown");
-               language_opts_set(ud->builder, "SourceAudioLang");
+               language_opts_set(ud->builder, "SrtLanguage");
+               language_opts_set(ud->builder, "PreferredLanguage");
+               srt_codeset_opts_set(ud->builder, "SrtCodeset");
                title_opts_set(ud->builder, "title");
                audio_track_opts_set(ud->builder, "AudioTrack", user_data);
                subtitle_track_opts_set(ud->builder, "SubtitleTrack", user_data);
                generic_opts_set(ud->builder, "VideoQualityGranularity", &vqual_granularity_opts);
+               generic_opts_set(ud->builder, "WhenComplete", &when_complete_opts);
                generic_opts_set(ud->builder, "PicturePAR", &par_opts);
                generic_opts_set(ud->builder, "PictureModulus", &alignment_opts);
                generic_opts_set(ud->builder, "LoggingLevel", &logging_opts);
+               generic_opts_set(ud->builder, "LogLongevity", &log_longevity_opts);
+               generic_opts_set(ud->builder, "check_updates", &appcast_update_opts);
                generic_opts_set(ud->builder, "FileFormat", &container_opts);
                generic_opts_set(ud->builder, "PictureDeinterlace", &deint_opts);
                generic_opts_set(ud->builder, "PictureDetelecine", &detel_opts);
@@ -2220,8 +2366,12 @@ ghb_update_ui_combo_box(
                        video_rate_opts_set(ud->builder, "VideoFramerate", hb_video_rates, hb_video_rates_count);
                else if (strcmp(name, "AudioMixdown") == 0)
                        mix_opts_set(ud->builder, "AudioMixdown");
-               else if (strcmp(name, "SourceAudioLang") == 0)
-                       language_opts_set(ud->builder, "SourceAudioLang");
+               else if (strcmp(name, "SrtLanguage") == 0)
+                       language_opts_set(ud->builder, "SrtLanguage");
+               else if (strcmp(name, "PreferredLanguage") == 0)
+                       language_opts_set(ud->builder, "PreferredLanguage");
+               else if (strcmp(name, "SrtCodeset") == 0)
+                       srt_codeset_opts_set(ud->builder, "SrtCodeset");
                else if (strcmp(name, "title") == 0)
                        title_opts_set(ud->builder, "title");
                else if (strcmp(name, "SubtitleTrack") == 0)
@@ -2246,7 +2396,9 @@ init_ui_combo_boxes(GtkBuilder *builder)
        init_combo_box(builder, "AudioSamplerate");
        init_combo_box(builder, "VideoFramerate");
        init_combo_box(builder, "AudioMixdown");
-       init_combo_box(builder, "SourceAudioLang");
+       init_combo_box(builder, "SrtLanguage");
+       init_combo_box(builder, "PreferredLanguage");
+       init_combo_box(builder, "SrtCodeset");
        init_combo_box(builder, "title");
        init_combo_box(builder, "AudioTrack");
        for (ii = 0; combo_name_map[ii].name != NULL; ii++)
@@ -2348,7 +2500,7 @@ ghb_ac3_in_audio_list(const GValue *audio_list)
 
                asettings = ghb_array_get_nth(audio_list, ii);
                acodec = ghb_settings_combo_int(asettings, "AudioEncoder");
-               if (acodec == HB_ACODEC_AC3)
+               if (acodec & HB_ACODEC_AC3)
                        return TRUE;
        }
        return FALSE;
@@ -2765,7 +2917,7 @@ picture_settings_deps(signal_user_data_t *ud)
 {
        gboolean autoscale, keep_aspect, enable_keep_aspect;
        gboolean enable_scale_width, enable_scale_height;
-       gboolean enable_disp_width, enable_disp_height;
+       gboolean enable_disp_width, enable_disp_height, enable_par;
        gint pic_par;
        GtkWidget *widget;
 
@@ -2787,6 +2939,7 @@ picture_settings_deps(signal_user_data_t *ud)
        enable_scale_width = !autoscale && (pic_par != 1);
        enable_scale_height = !autoscale && (pic_par != 1);
        enable_disp_width = (pic_par == 3) && !keep_aspect;
+       enable_par = (pic_par == 3) && !keep_aspect;
        enable_disp_height = FALSE;
 
        widget = GHB_WIDGET(ud->builder, "PictureModulus");
@@ -2801,6 +2954,10 @@ picture_settings_deps(signal_user_data_t *ud)
        gtk_widget_set_sensitive(widget, enable_disp_width);
        widget = GHB_WIDGET(ud->builder, "PictureDisplayHeight");
        gtk_widget_set_sensitive(widget, enable_disp_height);
+       widget = GHB_WIDGET(ud->builder, "PicturePARWidth");
+       gtk_widget_set_sensitive(widget, enable_par);
+       widget = GHB_WIDGET(ud->builder, "PicturePARHeight");
+       gtk_widget_set_sensitive(widget, enable_par);
        widget = GHB_WIDGET(ud->builder, "PictureKeepRatio");
        gtk_widget_set_sensitive(widget, enable_keep_aspect);
        widget = GHB_WIDGET(ud->builder, "autoscale");
@@ -2978,47 +3135,56 @@ ghb_set_scale(signal_user_data_t *ud, gint mode)
                // The scaler crashes if the dimensions are not divisible by 2
                // Align mod 2.  And so does something in x264_encoder_headers()
                job->anamorphic.modulus = mod;
+               job->anamorphic.par_width = title->pixel_aspect_width;
+               job->anamorphic.par_height = title->pixel_aspect_height;
+               job->anamorphic.dar_width = 0;
+               job->anamorphic.dar_height = 0;
+
                if (keep_height && pic_par == 2)
                        width = ((double)height * crop_width / crop_height) + 0.5;
                job->width = width;
                job->height = height;
-               if (max_width) 
-                       job->maxWidth = max_width;
-               if (max_height) 
-                       job->maxHeight = max_height;
+               job->maxWidth = max_width;
+               job->maxHeight = max_height;
                job->crop[0] = crop[0]; job->crop[1] = crop[1];
                job->crop[2] = crop[2]; job->crop[3] = crop[3];
                if (job->anamorphic.mode == 3 && !keep_aspect)
                {
-                       gint dar_width, dar_height;
+                       job->anamorphic.keep_display_aspect = 0;
                        if (mode & GHB_PIC_KEEP_PAR)
                        {
-                               par_width = ghb_settings_get_int(ud->settings, 
-                                                                                               "PicturePARWidth");
-                               par_height = ghb_settings_get_int(ud->settings, 
-                                                                                               "PicturePARHeight");
-                               dar_width = ((gdouble)width * par_width / par_height) + 0.5;
-                               dar_height = height;
+                               job->anamorphic.par_width = 
+                                       ghb_settings_get_int(ud->settings, "PicturePARWidth");
+                               job->anamorphic.par_height = 
+                                       ghb_settings_get_int(ud->settings, "PicturePARHeight");
                        }
                        else
                        {
-                               dar_width = ghb_settings_get_int(ud->settings, 
-                                                                                               "PictureDisplayWidth");
-                               dar_height = ghb_settings_get_int(ud->settings, 
-                                                                                               "PictureDisplayHeight");
+                               job->anamorphic.dar_width = 
+                                       ghb_settings_get_int(ud->settings, 
+                                                                               "PictureDisplayWidth");
+                               job->anamorphic.dar_height =
+                                       ghb_settings_get_int(ud->settings, 
+                                                                               "PictureDisplayHeight");
                        }
-                       job->anamorphic.dar_width = dar_width;
-                       job->anamorphic.dar_height = dar_height;
-                       job->anamorphic.keep_display_aspect = 0;
                }
                else
                {
-                       job->anamorphic.dar_width = 0;
-                       job->anamorphic.dar_height = 0;
                        job->anamorphic.keep_display_aspect = 1;
                }
                hb_set_anamorphic_size( job, &width, &height, 
                                                                &par_width, &par_height );
+               if (job->anamorphic.mode == 3 && !keep_aspect && 
+                       mode & GHB_PIC_KEEP_PAR)
+               {
+                       // hb_set_anamorphic_size reduces the par, which we
+                       // don't want in this case because the user is
+                       // explicitely specifying it.
+                       par_width = ghb_settings_get_int(ud->settings, 
+                                                                                       "PicturePARWidth");
+                       par_height = ghb_settings_get_int(ud->settings, 
+                                                                                               "PicturePARHeight");
+               }
        }
        else 
        {
@@ -3097,8 +3263,8 @@ ghb_set_scale(signal_user_data_t *ud, gint mode)
        }
        ghb_ui_update(ud, "display_aspect", ghb_string_value(str));
        g_free(str);
-       ghb_ui_update(ud, "par_width", ghb_int64_value(par_width));
-       ghb_ui_update(ud, "par_height", ghb_int64_value(par_height));
+       ghb_ui_update(ud, "PicturePARWidth", ghb_int64_value(par_width));
+       ghb_ui_update(ud, "PicturePARHeight", ghb_int64_value(par_height));
        ghb_ui_update(ud, "PictureDisplayWidth", ghb_int64_value(disp_width));
        ghb_ui_update(ud, "PictureDisplayHeight", ghb_int64_value(height));
        busy = FALSE;
@@ -3139,20 +3305,25 @@ set_preview_job_settings(hb_job_t *job, GValue *settings)
 
        gboolean keep_aspect;
        keep_aspect = ghb_settings_get_boolean(settings, "PictureKeepRatio");
-       if (job->anamorphic.mode == 3 && !keep_aspect)
+       if (job->anamorphic.mode)
        {
-               gint disp_width, disp_height;
-               disp_width = ghb_settings_get_int(settings, "PictureDisplayWidth");
-               disp_height = ghb_settings_get_int(settings, "PictureDisplayHeight");
-               job->anamorphic.dar_width = disp_width;
-               job->anamorphic.dar_height = disp_height;
-               job->anamorphic.keep_display_aspect = 0;
-       }
-       else
-       {
-               job->anamorphic.keep_display_aspect = 1;
+               job->anamorphic.par_width = job->title->pixel_aspect_width;
+               job->anamorphic.par_height = job->title->pixel_aspect_height;
                job->anamorphic.dar_width = 0;
                job->anamorphic.dar_height = 0;
+
+               if (job->anamorphic.mode == 3 && !keep_aspect)
+               {
+                       job->anamorphic.keep_display_aspect = 0;
+                       job->anamorphic.par_width = 
+                               ghb_settings_get_int(settings, "PicturePARWidth");
+                       job->anamorphic.par_height = 
+                               ghb_settings_get_int(settings, "PicturePARHeight");
+               }
+               else
+               {
+                       job->anamorphic.keep_display_aspect = 1;
+               }
        }
 }
 
@@ -3332,7 +3503,7 @@ ghb_validate_subtitles(signal_user_data_t *ud)
        gint mux = ghb_settings_combo_int(ud->settings, "FileFormat");
 
        const GValue *slist, *settings;
-       gint count, ii, track, source;
+       gint count, ii, source;
        gboolean burned, one_burned = FALSE;
 
        slist = ghb_settings_get_value(ud->settings, "subtitle_list");
@@ -3340,9 +3511,8 @@ ghb_validate_subtitles(signal_user_data_t *ud)
        for (ii = 0; ii < count; ii++)
        {
                settings = ghb_array_get_nth(slist, ii);
-               track = ghb_settings_combo_int(settings, "SubtitleTrack");
+               source = ghb_settings_get_int(settings, "SubtitleSource");
                burned = ghb_settings_get_boolean(settings, "SubtitleBurned");
-               source = ghb_subtitle_track_source(ud, track);
                if (burned && one_burned)
                {
                        // MP4 can only handle burned vobsubs.  make sure there isn't
@@ -3371,7 +3541,8 @@ ghb_validate_subtitles(signal_user_data_t *ud)
                        "Your chosen container does not support soft bitmap subtitles.\n\n"
                                "You should change your subtitle selections.\n"
                                "If you continue, some subtitles will be lost.");
-                       if (!ghb_message_dialog(GTK_MESSAGE_WARNING, message, "Cancel", "Continue"))
+                       if (!ghb_message_dialog(GTK_MESSAGE_WARNING, message, 
+                               "Cancel", "Continue"))
                        {
                                g_free(message);
                                return FALSE;
@@ -3379,6 +3550,27 @@ ghb_validate_subtitles(signal_user_data_t *ud)
                        g_free(message);
                        break;
                }
+               if (source == SRTSUB)
+               {
+                       gchar *filename;
+
+                       filename = ghb_settings_get_string(settings, "SrtFile");
+                       if (!g_file_test(filename, G_FILE_TEST_IS_REGULAR))
+                       {
+                               message = g_strdup_printf(
+                               "Srt file does not exist or not a regular file.\n\n"
+                                       "You should choose a valid file.\n"
+                                       "If you continue, this subtitle will be ignored.");
+                               if (!ghb_message_dialog(GTK_MESSAGE_WARNING, message, 
+                                       "Cancel", "Continue"))
+                               {
+                                       g_free(message);
+                                       return FALSE;
+                               }
+                               g_free(message);
+                               break;
+                       }
+               }
        }
        return TRUE;
 }
@@ -3749,8 +3941,30 @@ add_job(hb_handle_t *h, GValue *js, gint unique_id, gint titleindex)
                job->deinterlace = 0;
     job->grayscale   = ghb_settings_get_boolean(js, "VideoGrayScale");
 
+       gboolean keep_aspect;
+       keep_aspect = ghb_settings_get_boolean(js, "PictureKeepRatio");
        job->anamorphic.mode = ghb_settings_combo_int(js, "PicturePAR");
        job->anamorphic.modulus = ghb_settings_combo_int(js, "PictureModulus");
+       if (job->anamorphic.mode)
+       {
+               job->anamorphic.par_width = title->pixel_aspect_width;
+               job->anamorphic.par_height = title->pixel_aspect_height;
+               job->anamorphic.dar_width = 0;
+               job->anamorphic.dar_height = 0;
+
+               if (job->anamorphic.mode == 3 && !keep_aspect)
+               {
+                       job->anamorphic.keep_display_aspect = 0;
+                       job->anamorphic.par_width = 
+                               ghb_settings_get_int(js, "PicturePARWidth");
+                       job->anamorphic.par_height = 
+                               ghb_settings_get_int(js, "PicturePARHeight");
+               }
+               else
+               {
+                       job->anamorphic.keep_display_aspect = 1;
+               }
+       }
 
        /* Add selected filters */
        job->filters = hb_list_init();
@@ -3971,20 +4185,49 @@ add_job(hb_handle_t *h, GValue *js, gint unique_id, gint titleindex)
        gint subtitle;
        gboolean force, burned, def, one_burned = FALSE;
        
-       job->select_subtitle = NULL;
+       ghb_settings_set_boolean(js, "subtitle_scan", FALSE);
        subtitle_list = ghb_settings_get_value(js, "subtitle_list");
        count = ghb_array_len(subtitle_list);
        for (ii = 0; ii < count; ii++)
        {
                GValue *ssettings;
+               gint source;
 
                ssettings = ghb_array_get_nth(subtitle_list, ii);
 
-               subtitle = ghb_settings_get_int(ssettings, "SubtitleTrack");
                force = ghb_settings_get_boolean(ssettings, "SubtitleForced");
                burned = ghb_settings_get_boolean(ssettings, "SubtitleBurned");
                def = ghb_settings_get_boolean(ssettings, "SubtitleDefaultTrack");
+               source = ghb_settings_get_int(ssettings, "SubtitleSource");
+
+               if (source == SRTSUB)
+               {
+               hb_subtitle_config_t sub_config;
+                       gchar *filename, *lang, *code;
 
+                       filename = ghb_settings_get_string(ssettings, "SrtFile");
+                       if (!g_file_test(filename, G_FILE_TEST_IS_REGULAR))
+                       {
+                               continue;
+                       }
+                       sub_config.offset = ghb_settings_get_int(ssettings, "SrtOffset");
+                       lang = ghb_settings_get_string(ssettings, "SrtLanguage");
+                       code = ghb_settings_get_string(ssettings, "SrtCodeset");
+                       strncpy(sub_config.src_filename, filename, 128);
+                       strncpy(sub_config.src_codeset, code, 40);
+                       sub_config.force = 0;
+                       sub_config.dest = PASSTHRUSUB;
+                       sub_config.default_track = def;
+
+                       hb_srt_add( job, &sub_config, lang);
+
+                       g_free(filename);
+                       g_free(lang);
+                       g_free(code);
+                       continue;
+               }
+
+               subtitle = ghb_settings_get_int(ssettings, "SubtitleTrack");
                if (subtitle == -1)
                {
                        if (!burned && job->mux == HB_MUX_MKV)
@@ -4001,13 +4244,13 @@ add_job(hb_handle_t *h, GValue *js, gint unique_id, gint titleindex)
                                // Only allow one subtitle to be burned into the video
                                if (one_burned)
                                        continue;
+                               job->select_subtitle_config.dest = RENDERSUB;
                                one_burned = TRUE;
                        }
                        job->select_subtitle_config.force = force;
                        job->select_subtitle_config.default_track = def;
                        job->indepth_scan = 1;
-                       job->select_subtitle = malloc(sizeof(hb_subtitle_t*));
-                       *job->select_subtitle = NULL;
+                       ghb_settings_set_boolean(js, "subtitle_scan", TRUE);
                }
                else if (subtitle >= 0)
                {
@@ -4083,8 +4326,6 @@ add_job(hb_handle_t *h, GValue *js, gint unique_id, gint titleindex)
                 * for the second pass and then off again for the
                 * second.
                 */
-               hb_subtitle_t **subtitle_tmp = job->select_subtitle;
-               job->select_subtitle = NULL;
                job->pass = 1;
                job->indepth_scan = 0;
 
@@ -4124,12 +4365,15 @@ add_job(hb_handle_t *h, GValue *js, gint unique_id, gint titleindex)
 
                        job->x264opts = tmp_x264opts;
                }
+               else
+               {
+                       job->x264opts = x264opts;
+               }
                job->sequence_id = (unique_id & 0xFFFFFF) | (sub_id++ << 24);
                hb_add( h, job );
                //if (job->x264opts != NULL)
                //      g_free(job->x264opts);
 
-               job->select_subtitle = subtitle_tmp;
                job->pass = 2;
                /*
                 * On the second pass we turn off subtitle scan so that we